New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include null safety patches in repo #2

Open

purefundev opened this issue Jan 16, 2023 · 1 comment

purefundev commented Jan 16, 2023

Hi,

There is https://pub.dev/packages/pexels and https://pub.dev/packages/pexels_null_safety - both are pointing to this repo

The former does not work with modern Flutter. Nor does the master branch at the time of writing

If both pub packages are yours, would you mind publishing the null safety patches on GitHub too? If not in master then at least to a separate branch?

Cheers!

purefundev added a commit to purefundev/flutter_pexels_api that referenced this issue


          Adopt null safety changes from https://pub.dev/packages/pexels_null_s…

c8b0a47

…afety

The original project is published at
https://pub.dev/packages/pexels and https://github.com/xenoken/pexels

There are some null safety patches published as a separate pub package at
https://pub.dev/packages/pexels_null_safety
this package also refers to https://github.com/xenoken/pexels even though
the github repo doesn't contain those changes
(at least not yet, see xenoken#2 )

As a workaround, to be able to build on top of the fixed version in Git,
this commit overlays what's published as pexels_null_safety 0.1.2
on top of pexels 0.1.1, while retaining the shorter package name pexels

Author

purefundev commented Jan 16, 2023

Since I wanted this to work, I happened to spend a bit of time on it: added the null safety stuff, fixed a few other things ( see master of https://github.com/purefundev/flutter_pexels_api if you're interested) and published it as a separate package for now on pub.dev https://pub.dev/packages/pexels_api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment