Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query struct should not store types #148

Closed
fishcakez opened this issue Nov 13, 2016 · 1 comment
Closed

Query struct should not store types #148

fishcakez opened this issue Nov 13, 2016 · 1 comment

Comments

@fishcakez
Copy link
Contributor

Mariaex never uses types stored in the query struct. Instead it encodes parameters using Elixir types and lets MySQL cast the terms, getting a database error if it can not. On decode it uses the column description that is sent immediately before the rows. By storing and checking these types we introduce errors where we don't need to.

This raise was introduced in #145.

@fishcakez
Copy link
Contributor Author

This was fixed in eb08f78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant