Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to IString for all strings (where appropriate) #34

Open
xfbs opened this issue Oct 12, 2024 · 0 comments
Open

Move to IString for all strings (where appropriate) #34

xfbs opened this issue Oct 12, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@xfbs
Copy link
Owner

xfbs commented Oct 12, 2024 •
edited
Loading

We pass a lot of strings around in the components, and the recommendation is to use IString where possible because it is reference-counted and cheap to clone.
@xfbs xfbs added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xfbs