Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NativeImage cannot be cast to class customskinloader.fake.itf.IFakeNativeImage when legacy skin is loaded on Forge (but not on Fabric) #314

Closed
3 tasks done
Fourmisain opened this issue Nov 7, 2024 · 1 comment · Fixed by #315
Labels

Comments

@Fourmisain
Copy link

Describe the bug

This originated from dzwdz/chat_heads#117

Loading a legacy skin crashes on Forge (using ForgeV2_14.21), but not on Fabric, using (Fabric_14.21).

Steps to reproduce

1. In CustomSkinLoader.json, place `LocalSkin` first in `loadlist`
2. Put any legacy skin like https://mskins.net/en/skin/renagabe-w1RoX at LocalSkin\skins\USERNAME.png
3. Load a world and wait for the skin to load - the game crashes instead

Link to crash-report if applicable

https://mclo.gs/KfhXFa5

Link to CustomSkinLoader.log if applicable

https://mclo.gs/nxW5C6L

Link to latest.log if applicable

https://mclo.gs/EFN1Jyx

[Only Forge User] Link to Forge Log if applicable

No response

Mod Version

14.21

Minecraft Version

1.20.1

Minecraft Launcher Name and Version

PrismLauncher 9.1

Mod Loader

Forge

Operating System

Windows

Before submitting a bug report

  • This bug wasn't already reported (I have searched bug reports on GitHub).

  • This is a valid bug (I am able to reproduce this on the latest dev build).

  • This problem is triggered in the latest version of the mod (if not the latest please upgrade the mod first)

@Fourmisain Fourmisain added the bug label Nov 7, 2024
ZekerZhayard added a commit to ZekerZhayard/MCCustomSkinLoader that referenced this issue Nov 7, 2024
@ZekerZhayard ZekerZhayard mentioned this issue Nov 7, 2024
@ZekerZhayard
Copy link
Collaborator

#315

@xfl03 xfl03 closed this as completed in #315 Nov 8, 2024
@xfl03 xfl03 closed this as completed in 571d611 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants