Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoidStruts buggy when used in combination with some other layout hook #112

Closed
colonelpanic8 opened this issue Nov 3, 2016 · 5 comments
Closed

Comments

@colonelpanic8
Copy link
Contributor

I have an admittedly somewhat complex layout hook, but something about it makes avoidStuts stop working whenever I press Mod+Shift+Enter to reset layouts.

this could also have to do with an interaction between the jump to layout version of ||| from XMonad.Layout.LayoutCombinators and avoidStruts. I'll try to look at this more deeply sometime this week, but I thought I'd post this here in case anyone else encounters this or someone knows something about this issue.

Here is my layout hook, for reference:

myLayoutHook = avoidStruts . smartSpacing 10 . minimize . boringWindows .
               mkToggle (MIRROR ?? EOT) . workspaceNamesHook . smartBorders .
               noBorder $ layouts
@f1u77y
Copy link
Contributor

f1u77y commented Nov 3, 2016

That's becuase it stores struts in layout state which is reset when you reset layouts. #80 should fix your issue.

@geekosaur
Copy link
Contributor

On Thu, Nov 3, 2016 at 4:42 PM, Ivan Malison [email protected]
wrote:

I have an admittedly somewhat complex layout hook, but something about it
makes avoidStuts stop working whenever I press Mod+Shift+Enter to reset
layouts.

If you are running xmonad-contrib from git, this is a shortcoming of the
current strut cache: resetting the layout clears the cache, so you need to
rebind mod-shift-space to something like asks (layoutHook . config) >>= setLayout >> docksStartupHook.

brandon s allbery kf8nh sine nomine associates
[email protected] [email protected]
unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

@byorgey
Copy link
Member

byorgey commented Nov 3, 2016

#80 has now been merged, which should fix this. Feel free to reopen if you're still seeing the issue.

@byorgey byorgey closed this as completed Nov 3, 2016
@colonelpanic8
Copy link
Contributor Author

I'm still seeing this issue, even after #80 (I running xmonad-contrib compiled from git).

@geekosaur
Copy link
Contributor

#80 (comment)
says that #80 will not fix the problem with layouts not delegating to their
sublayouts properly (#76), which is much more likely to be your problem.

On Wed, Nov 9, 2016 at 4:32 PM, Ivan Malison [email protected]
wrote:

I'm still seeing this issue, even after #80
#80 (I running
xmonad-contrib compiled from git).


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#112 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB8SoMBUzz6X7TDxaASjYy91Hjp1P7Grks5q8jvsgaJpZM4Ko5Dx
.

brandon s allbery kf8nh sine nomine associates
[email protected] [email protected]
unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants