Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Rename fetch_installation_keys to get_identity_updates #62

Open
insipx opened this issue Feb 13, 2024 · 0 comments
Open

Feature request: Rename fetch_installation_keys to get_identity_updates #62

insipx opened this issue Feb 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@insipx
Copy link
Contributor

insipx commented Feb 13, 2024 •
edited
Loading

Is your feature request related to a problem?

In libxmtp, fetch_installation_keys refers to key packages, while get_identity_updates refers to getting installation ids associated with a wallet address

Describe the solution to the problem

We should rename fetch_installation_keys in order to remain consistent across codebases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
D14N Work
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename fetch_key_packages to get_identity_updates xmtp/xps-gateway
1 participant
@insipx