Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xnd constructor parameter mutual exclusivity check limit incorrect. #21

Open
dmgass opened this issue May 30, 2018 · 0 comments
Open

xnd constructor parameter mutual exclusivity check limit incorrect. #21

dmgass opened this issue May 30, 2018 · 0 comments

Comments

@dmgass
Copy link

dmgass commented May 30, 2018

https://github.com/plures/xnd/blob/ad42562ee39bf96b7e40a4d11c502f882f22bcc3/python/xnd/__init__.py#L103

The check includes a tally of 5 parameters. The limit (2) would be correct for 4 parameters. This check is catching some use cases, but not all.

I'm guessing this is unpolished and wasn't tuned to completely shut out the invalid use cases in order to accommodate dtype being needed when values are supplied for typedef and dtypedef. Let me know if submissions like this are unhelpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant