Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag for conda-build. #10

Open
skrah opened this issue Aug 23, 2018 · 7 comments
Open

Add tag for conda-build. #10

skrah opened this issue Aug 23, 2018 · 7 comments

Comments

@skrah
Copy link
Member

skrah commented Aug 23, 2018

The conda version string relies on at least one tag, currently we get (https://anaconda.org/xnd/xndtools/files):

xndtools-0.2.0dev3-py36_NA.tar.bz2

With a tag we should get something like:

libndtypes-0.2.0dev3-py36_153_g9b6806c.tar.bz2

Any named tag is fine, I'm using v0.2.0b2, meaning that dev3 will lead either to b3or to a release.

@skrah
Copy link
Member Author

skrah commented Aug 23, 2018

The tag only needs to be in xndtools, the subtrees in xnd-all should not have tags I think.

@pearu
Copy link
Member

pearu commented Aug 23, 2018

Where do you add the tag? I'd like to use a tag derived from git commit id.

@pearu
Copy link
Member

pearu commented Aug 23, 2018

@skrah Note that 0.2.0dev3 does not comply PEP 440,
it should read 0.2.0.dev3.

@skrah
Copy link
Member Author

skrah commented Aug 23, 2018

I know, but I think I had some conda issues with 0.2.0.dev3 (conda may have normalized something, I don't recall exactly), but try 0.2.0.dev3.

I missed the v0.2.0dev3 tag in ndtypes, so I'd do in xndtools:

$ git tag "v0.2.0dev3" -a
$ git describe --tags
v0.2.0dev3

Conda uses git describe --tags, so after the next commit you get the commit id automatically:

$ vi README.md 
$ git add -u
$ 
$ git commit
[master 5dee7da] Example commit.
 1 file changed, 1 deletion(-)
$ 
$ git describe --tags
v0.2.0dev3-1-g5dee7da

@skrah
Copy link
Member Author

skrah commented Aug 23, 2018

It may also have been distutils issues with 0.2.0.dev3. I just recall that something did not work, perhaps even uploading to PyPI.

@pearu
Copy link
Member

pearu commented Aug 23, 2018

In xndtools I am using 0.2.0.dev3 because when using PYTHONWARNINGS=default then I remember seeing a warning that 0.2.0dev3 is converted to 0.2.0.dev3.
I'll keep using it to see where it causes problems.

@skrah
Copy link
Member Author

skrah commented Aug 23, 2018

Yes, let's watch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants