Add an option <extraArgs> to let user pass custom parameters to protoc command #79

sebastienvermeille · 2021-05-05T09:38:30Z

Add an option to let user pass custom parameters to protoc command

That way we can use all available protoc plugins with their custom options

Applicable Issues
Fixes #61 #77

Description
Add configuration (optional) which is appended in the the protoc command invoked by the maven plugin.
This way we can easily address the issue of wanting to pass some specific parameters to protoc when running the plugin.

In my case I needed to pass some specific plugin arguments:

      <plugin>
        <groupId>org.xolstice.maven.plugins</groupId>
        <artifactId>protobuf-maven-plugin</artifactId>
        <executions>
          <execution>
            <id>protodoc</id>
            <goals>
              <goal>compile-custom</goal>
            </goals>
            <configuration>
              <pluginId>protoc-gen-doc</pluginId>
              <pluginExecutable>${project.build.directory}/protoc-plugins/protoc-gen-doc-1.4.1.linux-amd64.go1.15.2/protoc-gen-doc</pluginExecutable>
              <outputDirectory>${project.build.directory}/doc</outputDirectory>
              <extraArgs>--protoc-gen-doc_opt=markdown,README.md</extraArgs>
            </configuration>
          </execution>
        </executions>
        <configuration>
          <protocArtifact>com.google.protobuf:protoc:3.4.0:exe:${os.detected.classifier}</protocArtifact>
        </configuration>
      </plugin>

This way I can pass --protoc-gen-doc_opt=markdown,README.md and everything works fine.

Happy to be able to contribute to a such great project! I stay available for more assistance on it and to discuss it of course thank you 👍

…otoc command That way we can use all available protoc plugins with their custom options

bfmyr4 · 2022-01-13T19:07:08Z

Any chance on getting this into a new release?

annyugen · 2022-01-24T21:47:20Z

Also curious on this update. Really love to have this so I can configure NullAway to not scan generated classes

sebastienvermeille · 2022-02-15T07:33:18Z

Hi, okay it seems that this project is no longer maintained, I will fork it and host it on maven myself. @nguyenAn1201 @bfmyr4 sorry for the delay, I will ping you when it's ready if you still need it :)

seime · 2022-02-15T08:52:15Z

Hi @sebastienvermeille , are you intending to become the new maintainer if this project, and by that review and merge PRs? If so I applaud you, and we're happy to switch to your releases when available.

Cheers

sebastienvermeille · 2022-08-02T09:23:48Z

@seime Yes it's on my plans but unfortunately lack a bit of time.

If you need this PR code in your projects I hosted it already on maven central:

<dependency>
  <groupId>dev.cookiecode</groupId>
  <artifactId>protobuf-maven-plugin</artifactId>
  <version>0.7.1</version>
  <type>maven-plugin</type>
</dependency>

… different IDE, OS That way contributors don't push undesired files by accident

…ject

…of the plugin That way they don't get annoyed for issues not related to their responsibility

That way we no longer have any strong link with the xolstice code anymore (avoid confusion)

Take ownership

Adapt for gh-pages and adapt versions changelog

Integrate sonarqube analysis, hide unused ribbon yet

…er to get own badges for this project Remove old CI stuff, will redo it using github actions

Replace Charset.forName() with constants UTF_8

seime · 2022-09-06T08:23:56Z

@seime Yes it's on my plans but unfortunately lack a bit of time.

If you need this PR code in your projects I hosted it already on maven central:

Thanks @sebastienvermeille , we have switched to your fork. Looking forward to next releases!

sergei-ivanov · 2023-05-18T22:51:20Z

@sebastienvermeille would you like to officially take over the project as a principal committer?

sebastienvermeille · 2023-06-29T13:38:38Z

@sergei-ivanov yes would be great as it's a central lib for many other projects I would like to do that for sure.
Let's have a talk

Add an option <extraArgs> which let user pass custom parameters to pr…

7beb184

…otoc command That way we can use all available protoc plugins with their custom options

sebastienvermeille and others added 24 commits August 4, 2022 08:35

Use gitignore.io to generate .gitignore file and enforce also against…

ecee4f8

… different IDE, OS That way contributors don't push undesired files by accident

Add myself in AUTHORS as I become now the main maintainer of this pro…

2b3a1bc

…ject

Remove links to xolstice which is no longer maintaining this variant …

dbb988d

…of the plugin That way they don't get annoyed for issues not related to their responsibility

Remove links to xolstice which is no longer maintaining this variant …

9186aef

…of the plugin That way they don't get annoyed for issues not related to their responsibility

Rename packages

72ded9b

That way we no longer have any strong link with the xolstice code anymore (avoid confusion)

Rename maven properties

c337dcf

Rename maven properties

c12df1f

Adapt for gh-pages

ee038a8

Merge pull request #1 from sebastienvermeille/take-ownership

2e007cf

Take ownership

Introduce and test github actions

ef0a6ce

Adapt for gh-pages and adapt versions changelog

6733d80

Merge pull request #3 from sebastienvermeille/take-ownership

58757ec

Adapt for gh-pages and adapt versions changelog

Update

a471c42

update

8596b56

update

54650f6

update

5fb2e63

update

5e0b42e

update

d6cef1f

update

92d1325

Update pom.xml

c8b6bd7

Update pom.xml

bb09708

update

8bc19e6

Update release.yml

d4867dc

Update release.yml

5a6bc00

sebastienvermeille and others added 17 commits August 4, 2022 15:24

Update release.yml

0f35d25

Update release.yml

5900c13

Update release.yml

d52c0a5

Update release.yml

e7d851b

update

7764d76

Update release.yml

9468cee

Update release.yml

c3182b0

Update release.yml

73dbedb

Update release.yml

a138740

Update release.yml

1640dbe

Integrate sonarqube analysis, hide unused ribbon yet

eaa715c

Merge pull request #4 from sebastienvermeille/cleanup

7cd380b

Integrate sonarqube analysis, hide unused ribbon yet

Integrate sonarqube analysis, hide unused ribbon yet

116e7b1

Merge pull request #5 from sebastienvermeille/cleanup

fb3de06

Integrate sonarqube analysis, hide unused ribbon yet

Replace Charset.forName() with constants UTF_8

4b35501

Improve README.md using all badges, subscribe to openssf, snyk in ord…

c1c624e

…er to get own badges for this project Remove old CI stuff, will redo it using github actions

Merge pull request #6 from sebastienvermeille/fix-sonar-issues

34f9ae4

Replace Charset.forName() with constants UTF_8

sebastienvermeille closed this May 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an option <extraArgs> to let user pass custom parameters to protoc command #79

Add an option <extraArgs> to let user pass custom parameters to protoc command #79

sebastienvermeille commented May 5, 2021 •

edited

Loading

bfmyr4 commented Jan 13, 2022

annyugen commented Jan 24, 2022

sebastienvermeille commented Feb 15, 2022

seime commented Feb 15, 2022

sebastienvermeille commented Aug 2, 2022

seime commented Sep 6, 2022

sergei-ivanov commented May 18, 2023

sebastienvermeille commented Jun 29, 2023

Add an option <extraArgs> to let user pass custom parameters to protoc command #79

Add an option <extraArgs> to let user pass custom parameters to protoc command #79

Conversation

sebastienvermeille commented May 5, 2021 • edited Loading

Add an option to let user pass custom parameters to protoc command

bfmyr4 commented Jan 13, 2022

annyugen commented Jan 24, 2022

sebastienvermeille commented Feb 15, 2022

seime commented Feb 15, 2022

sebastienvermeille commented Aug 2, 2022

seime commented Sep 6, 2022

sergei-ivanov commented May 18, 2023

sebastienvermeille commented Jun 29, 2023

sebastienvermeille commented May 5, 2021 •

edited

Loading