Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling of move_to_first #181

Open
CJ-Wright opened this issue Apr 13, 2019 · 0 comments
Open

better handling of move_to_first #181

CJ-Wright opened this issue Apr 13, 2019 · 0 comments

Comments

@CJ-Wright
Copy link
Member

Current behavior causes the graph to be recreated as it was initialized, if move_to_first is used then we don't capture the changes to the graph structure. We need to do that better.
This is particularly difficult as a move_to_first use case is handling tricky diamond dependencies where we can't actually init downstream things with the correct execution order.

One approach could be to stash the upstreams in the serialized graph. On deserialization we could then create all the nodes via the init information and then finally reorder the graph accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant