Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate bootchartd poking with arguments #27

Open
xrmx opened this issue Jul 6, 2011 · 0 comments
Open

Investigate bootchartd poking with arguments #27

xrmx opened this issue Jul 6, 2011 · 0 comments

Comments

@xrmx
Copy link
Owner

xrmx commented Jul 6, 2011

130d775 introduced reading the value of bootchart_init from an environment variable. Since this is a lot cleaner that looping on arguments i think we should investigate if the old code may be safely removed.

This is an excerpt of his findings:

bootparam(7) says that all parameters interpreted by the kernel are
stripped. That means, init=blah never makes it to bootchartd. Unless
using an initrd (which I am not) somehow depends on it, I think the
entire for-loop can go without checking $init at all.

This is also what I observe (now on Linux 3.0-rc1 :-)). The exact
(perhaps not very exciting) details follow. My kernel command line is:

root=/dev/sda3 ro init=/sbin/bootchartd resume=/dev/sda2 initcall_debug printk.time=y bootchart_init=/bin/systemd

Bootchartd has the following environment variables set (by calling "env"
just before checking for $bootchart_init):

TERM=linux
PWD=/
bootchart_init=/bin/systemd
SHLVL=1
HOME=/
BOOT_IMAGE=/vmlinuz-3.0.0-rc1
_=/bin/env

And $@ is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant