Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying multiple network interfaces #34

Closed
xxxserxxx opened this issue Feb 15, 2020 · 3 comments
Closed

Allow specifying multiple network interfaces #34

xxxserxxx opened this issue Feb 15, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone
v3.2.0

Comments

@xxxserxxx
Copy link
Owner

Currently, only 1 network interface can be selected with the -i option, but it would be nice to be able to specify a list of interfaces.
@xxxserxxx xxxserxxx added the enhancement New feature or request label Feb 15, 2020
@xxxserxxx
Copy link
Owner Author

Hey @cjbassi I'm implementing this and possibly #149 at the same time, but docopt can't use options with multiple argument.

I think there's two options here:

  • Repeating the interfaces (and maybe specify excluded):
gotop -i wlp2s0 -i br-aad9862f577f -e tun0

Or:

  • Specify a list(split on ',' and remove from stats on '!'):
gotop -i wlp2s0,br-aad9862f577f,!tun0

What do you think?

@xxxserxxx
Copy link
Owner Author

Hey thanks for working on this. I was thinking the second option, that seems more ergonomic to me.

@xxxserxxx xxxserxxx added this to the v3.2.0 milestone Feb 20, 2020
@xxxserxxx
Copy link
Owner Author

Merged and released in v3.2.0

@mattLLVW FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
1 participant
@xxxserxxx