-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative path that goes into the parent folder and anchors #234
Open
Mylloon
wants to merge
13
commits into
xy2z:master
Choose a base branch
from
Mylloon:fix-img
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, not working when the asset isn't local |
* support link (tag <a>) for locals files
* add support for anchors (xy2z#157)
Mylloon
changed the title
Relative path that goes into the parent folder
Relative path that goes into the parent folder and anchors
Jul 12, 2022
I changed a bit how the links work, I probably didn't do enough testing, tell me what you think! But anchors should work |
Order is important on the list because if a very often used element is at the end, all irrelevant elements will have to be iterated before, I tried to do the best but I don't know everyone's habits (and it shouldn't have a huge impact either)
The only problem I see (for now) is when I open a file that links to another document, it doesn't update the table of contents on the side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block.attributes.src.value
instead ofblock.src
(example:../something.png
).