[NBS] Asynchronous disks allocation #2763
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
3 times, most recently
from
e6ba142 to
7f1eb3a
Compare
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
2 times, most recently
from
38c1991 to
9842b53
Compare
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
from
9842b53 to
2460bac
Compare
ya-ksgamora
changed the title
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_secure_erase.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/model/pending_cleanup.h
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/model/pending_cleanup.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
added
large-tests
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
from
2460bac to
3590307
Compare
|
Нужно привязать github issue к пулл реквесту и заполнить описание ПРа |
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
3 times, most recently
from
720fd6e to
6015df7
Compare
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
3 times, most recently
from
b6c0697 to
9692eeb
Compare
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
from
9692eeb to
4b7a4d7
Compare
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
from
e12bcae to
471537b
Compare
|
TODO:
|
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
from
471537b to
4cf02dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2945
We want local disks to deallocate asynchronously (disk is deleted instantly, its devices marked dirty and SecureErased afterwards) and allocate synchronously (meaning if there's no clean devices, we use free dirty devices and do not respond to allocation request until dirty devices allocated to disk are secure erased)
This PR acheives that by adding
PendingAllocationby example of existingPendingDeallocation.If devices of the disk are never cleaned, the request will stuck. There are only two cases for local disk device when SecureErase can't succeed:
For this reason added check for device/agent's devices pending allocation if they transition to "bad" state