From f3cb9d96a253382e4ad11fb50c86d7476690af9c Mon Sep 17 00:00:00 2001 From: ivanmorozov333 Date: Wed, 22 Jan 2025 17:09:16 +0300 Subject: [PATCH] fix tsan alerts --- .../engines/reader/common_reader/iterator/fetching.cpp | 4 ++-- .../engines/reader/common_reader/iterator/fetching.h | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.cpp b/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.cpp index 800ffb2dcbed..5d564d16bb25 100644 --- a/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.cpp +++ b/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.cpp @@ -120,8 +120,8 @@ void TFetchingScript::Allocation(const std::set& entityIds, const EStageFe TString IFetchingStep::DebugString() const { TStringBuilder sb; - sb << "name=" << Name << ";duration=" << SumDuration << ";" - << "size=" << 1e-9 * SumSize << ";details={" << DoDebugString() << "};"; + sb << "name=" << Name << ";duration=" << TDuration::MicroSeconds(SumDurationUs.Val()) << ";" + << "size=" << 1e-9 * SumSize.Val() << ";details={" << DoDebugString() << "};"; return sb; } diff --git a/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.h b/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.h index d0d6ae6d5840..b26c821549a8 100644 --- a/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.h +++ b/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.h @@ -67,8 +67,8 @@ class TFetchingStepsSignalsCollection: public NColumnShard::TCommonCountersOwner class IFetchingStep: public TNonCopyable { private: YDB_READONLY_DEF(TString, Name); - YDB_READONLY(TDuration, SumDuration, TDuration::Zero()); - YDB_READONLY(ui64, SumSize, 0); + YDB_READONLY_DEF(TAtomicCounter, SumDurationUs); + YDB_READONLY_DEF(TAtomicCounter, SumSize); TFetchingStepSignals Signals; protected: @@ -79,11 +79,11 @@ class IFetchingStep: public TNonCopyable { public: void AddDuration(const TDuration d) { - SumDuration += d; + SumDurationUs.Add(d.MicroSeconds()); Signals.AddDuration(d); } void AddDataSize(const ui64 size) { - SumSize += size; + SumSize.Add(size); Signals.AddBytes(size); }