Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkpoint storage: use more query parameters and settings #13755

Merged
merged 2 commits into from
Jan 29, 2025
Merged

checkpoint storage: use more query parameters and settings #13755

merged 2 commits into from
Jan 29, 2025

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Jan 23, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 11:41:15 UTC Pre-commit check linux-x86_64-release-asan for 8b71367 has started.
⚪ 2025-01-23 11:41:27 UTC Artifacts will be uploaded here
⚪ 2025-01-23 11:44:26 UTC ya make is running...
⚫ 2025-01-23 12:32:25 UTC Check cancelled

yumkam
yumkam commented Jan 23, 2025
View reviewed changes
ydb/core/fq/libs/checkpoint_storage/ydb_state_storage.cpp
@@ -726,8 +726,8 @@ TFuture<TIssues> TStateStorage::DeleteGraph(const TString& graphId) {

DELETE
FROM %s
WHERE graph_id = "%s";
)", prefix.c_str(), StatesTable, graphId.c_str());
WHERE graph_id = $graph_id;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(тут $graph_id декларирован, передан, но не используется)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 11:41:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b71367 has started.
⚪ 2025-01-23 11:41:54 UTC Artifacts will be uploaded here
⚪ 2025-01-23 11:44:54 UTC ya make is running...
⚫ 2025-01-23 12:32:25 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 12:34:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2fcb3da has started.
⚪ 2025-01-23 12:34:22 UTC Artifacts will be uploaded here
⚪ 2025-01-23 12:38:01 UTC ya make is running...
🟡 2025-01-23 13:30:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25118 22571 0 8 2411 128

⚪ 2025-01-23 13:33:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-23 13:48:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 91 0 0 0 119

🟢 2025-01-23 13:49:05 UTC Build successful.
🟢 2025-01-23 13:49:26 UTC ydbd size 2.1 GiB changed* by +15.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bd79c91 merge: 2fcb3da diff diff %
ydbd size 2 220 428 304 Bytes 2 220 443 944 Bytes +15.3 KiB +0.001%
ydbd stripped size 469 670 576 Bytes 469 675 440 Bytes +4.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 12:34:02 UTC Pre-commit check linux-x86_64-release-asan for 2fcb3da has started.
⚪ 2025-01-23 12:34:36 UTC Artifacts will be uploaded here
⚪ 2025-01-23 12:38:33 UTC ya make is running...
🟡 2025-01-23 13:37:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11053 10983 0 28 13 29

⚪ 2025-01-23 13:38:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 13:50:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 74 0 3 3 26

⚪ 2025-01-23 13:50:45 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-23 14:02:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 25 0 3 3 23

🟢 2025-01-23 14:02:54 UTC Build successful.
🟢 2025-01-23 14:03:23 UTC ydbd size 3.6 GiB changed* by +8.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bd79c91 merge: 2fcb3da diff diff %
ydbd size 3 858 261 672 Bytes 3 858 270 352 Bytes +8.5 KiB +0.000%
ydbd stripped size 1 349 573 328 Bytes 1 349 575 568 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as ready for review January 27, 2025 12:56
@yumkam yumkam requested a review from a team as a code owner January 27, 2025 12:56
@yumkam yumkam changed the title checkpoint storage: use more query parameters checkpoint storage: use more query parameters and settings Jan 29, 2025
@yumkam yumkam merged commit 5c07270 into ydb-platform:main Jan 29, 2025
13 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Jan 29, 2025
@yumkam
checkpoint storage: use more query parameters and settings (ydb-platf…
e8fc714 
…orm#13755)

(cherry picked from commit 5c07270)
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 30, 2025
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Jan 30, 2025
@yumkam @stanislav-shchetinin
checkpoint storage: use more query parameters and settings (ydb-platf…
9dc2d87 
…orm#13755)
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@yumkam @azevaykin
checkpoint storage: use more query parameters and settings (ydb-platf…
c44e742 
…orm#13755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kardymonds kardymonds kardymonds approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yumkam @kardymonds