-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change :geom
and empty column names to :geometry
#453
Comments
Are we able to get a consensus on this? I think this would be good to standardize as early on as possible. |
I think we just need a PR |
I've read the discussions etc, and am supportive of this. Can we make sure the implementation allows users to opt-in/out of it? |
I guess we can have a |
So are we just adding an option to rename the geometry column in: Line 1 in 2e0a4a7
|
A decision was made to standardize geometry name in GeoDataFrames.jl... this issue can be closed. |
The default gdal geometry column name
:geom
is now in conflict with the GeoInterace.jl default of:geometry
and julias tendency to spell things out. We haveGeoInterface.geometrycolumns
for packages, but its clunky for interactive use. Users want to just get the geometry column from a data frame in the normal dataframe syntax, with e.g.df.geometry
and currently they are left guessing which package uses which name.The fact that empty names are allowed is also a problem for users.
So I'm proposing we switch both
:geom
and empty names to:geometry
.JuliaGeo/GeoInterface.jl#164
The text was updated successfully, but these errors were encountered: