Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change :geom and empty column names to :geometry #453

Open
rafaqz opened this issue Dec 5, 2024 · 6 comments
Open

Change :geom and empty column names to :geometry #453

rafaqz opened this issue Dec 5, 2024 · 6 comments

Comments

@rafaqz
Copy link
Collaborator

rafaqz commented Dec 5, 2024

The default gdal geometry column name :geom is now in conflict with the GeoInterace.jl default of :geometry and julias tendency to spell things out. We have GeoInterface.geometrycolumns for packages, but its clunky for interactive use. Users want to just get the geometry column from a data frame in the normal dataframe syntax, with e.g. df.geometry and currently they are left guessing which package uses which name.

The fact that empty names are allowed is also a problem for users.

So I'm proposing we switch both :geom and empty names to :geometry.

JuliaGeo/GeoInterface.jl#164

@alex-s-gardner
Copy link
Contributor

Are we able to get a consensus on this? I think this would be good to standardize as early on as possible.

@rafaqz
Copy link
Collaborator Author

rafaqz commented Dec 12, 2024

I think we just need a PR

@yeesian
Copy link
Owner

yeesian commented Dec 12, 2024

I've read the discussions etc, and am supportive of this. Can we make sure the implementation allows users to opt-in/out of it?

@rafaqz
Copy link
Collaborator Author

rafaqz commented Dec 12, 2024

I guess we can have a geometrycolum keyword with :geometry as the default?

@alex-s-gardner
Copy link
Contributor

So are we just adding an option to rename the geometry column in:

function Tables.schema(

@alex-s-gardner
Copy link
Contributor

A decision was made to standardize geometry name in GeoDataFrames.jl... this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants