-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can’t report Unicode strings anymore #5
Comments
BTW I believe these lines:
Should probably be not in a comment, but in actual code (I think browser-provided atob/btoa are somewhat faster) |
@tonsky dangit. I'm very sorry this has caused you problems. That commit was introduced because Yeller was seeing errors where some browsers were sending invalid JSON to Yeller's servers. As such all the characters it sends have to be url safe. I'll dig into diagnosing and fixing this, but it's a somewhat nasty problem. |
Hmm, interesting :) Sure, cross-domain requests are hard
Quick summary: JSON spec allows for escaping any character with Not sure about its performance though. |
@tonsky that might work. Performance of the encoding isn't too important for JS clients, the blobs are relatively small most of the time, and it's on the user's side. |
ping |
I understand it’s because of this commit: 93067d1
I’m positive I’ve reported unicode messages before. What is the motivation behind this change? Why is exception so cryptic (“Dom Error 5” instead of “Can’t report unicode” or something)? What’s the recommended way to convert UTF-8 to ASCII from this point on?
The text was updated successfully, but these errors were encountered: