Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Copy + Clone for MaxpTable and CmapSubtable #39

Closed
fschutt opened this issue Dec 8, 2020 · 3 comments
Closed

Derive Copy + Clone for MaxpTable and CmapSubtable #39

fschutt opened this issue Dec 8, 2020 · 3 comments

Comments

@fschutt
Copy link
Contributor

fschutt commented Dec 8, 2020

Also it would be great if lookup_glyph_index was on the owned::CmapSubtable - together with conversion function to convert from a CmapSubtable<'a> to an owned::CmapSubtable and back - this way users can cache the CmapSubtable if needed.

I'm trying to create a struct that "owns" the cmap subtable, but if I create an OwnedCmapSubtable then looking up glyphs isn't available anymore

@fschutt
Copy link
Contributor Author

fschutt commented Dec 8, 2020

Also, please make the fields of SequentialMapGroup public

fschutt added a commit to fschutt/allsorts that referenced this issue Dec 8, 2020
fschutt added a commit to fschutt/allsorts that referenced this issue Dec 8, 2020
@fschutt
Copy link
Contributor Author

fschutt commented Dec 8, 2020

See #40

@wezm
Copy link
Contributor

wezm commented Dec 8, 2020

Hmm right. The owned variant primarily exists to support writing fonts as part of subsetting. All of our glyph handling code goes via the Font type — if you're not already using it I'd suggest taking a look as it's intended to be the primary shaping interface. It handles several caches but does not yet have a full glyph cache.

wezm pushed a commit that referenced this issue Dec 15, 2020
@wezm wezm closed this as completed in 09c16d6 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants