Font::supports_emoji should consider existence of COLR/CPAL tables

[ctrlcctrlv]

Just asking if the font has embedded images, as is currently done—

allsorts/src/font.rs

Lines 620 to 625 in fef3d22

	pub fn supports_emoji(&mut self) -> bool {
	match self.embedded_images() {
	Ok(Some(_)) => true,
	_ => false,
	}
	}

Is insufficient. Fonts may have embedded images, and only put them in the Latin range. Fonts may have no embedded images, but support emoji via COLR/CPAL—that's more common today on non-Apple platforms, actually.

Just an FYI.

[wezm]

Yes this method is perhaps poorly named. It's used by other code to determine when it should attempt to try to retrieve embedded images. Since we don't currently support COLR/CPAL it doesn't make sense to return true for that case. And you're right that embedded images may exist for non-emoji glyphs. I'll come up with a better name.

[wezm]

Fixed in 7308f27