-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allsorts seems to ignore shaping rules on the Latin range #44
Comments
Which particular differences did you notice? Different glyphs in the output or positioning information (or something else)? |
The positioning wasn't even checked by me to be correct because it's choosing the wrong glyphs. "Shape me!" (using glyphs "Shape me!" (using GSUB rules w/feature
hb-shape dist/FRBAmericanCursive-400-Regular.otf "Shape me!" --no-positions --ned |
The thing about this font is that even a single Latin letter needs GSUB to render correctly, to get the tail.
Another font of mine that requires GSUB to render correctly is TT2020.
But the command |
Thanks for the info. I'll look into it. I'm pretty confident that it will work one way or another. It's possibly a limitation of the <html>
<head>
<style>
@font-face {
font-family: "FRB American Cursive";
font-weight: normal;
font-style: normal;
font-stretch: normal;
src: url("/home/wmoore/Downloads/FRBAmericanCursive/dist/FRBAmericanCursive-400-Regular.otf")
}
body {
font-family: "FRB American Cursive";
font-size: 48pt;
}
</style>
</head>
<body>
<p>Shape me!</p>
</body>
</html> |
That is interesting. Could it be failure to fallback when script/lang is DFLT/dflt? |
Ok so I looked into it and as far as I can see the Allsorts output matches Harfbuzz, it's just that the output we generate is different to
Comparing these you can see that the same glyphs are present after shaping. |
Would you accept a patch to output the glyph name and not just its index? |
If the idea is to resolve the glyph name from the glyph id in the output glyphs within There's already some glyph name related code present for the |
Thanks. I'll try to open a PR to do that. :) Considering this closed because as you showed the glyph indexes are actually correct, I was just reading the output wrong. |
Comparison of hb-shape and allsorts against my font, FRB American Cursive:
allsorts
hb-shape
The text was updated successfully, but these errors were encountered: