You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for such a useful crate! As currently implemented, the use of the flate2/zlib feature in Cargo.toml prevents compiling to WASM, since zlib is not available. Would it be possible to make this dependency optional? Something like the following would do it:
The flate2/zlib feature is now exposed by allsorts/zlib, which is added to the default features. So by default everything remains exactly the same. But now consumers who want to compile to WASM (or other scenarios where zlib is not available) can remove that feature and use the allsorts/miniz_oxide feature instead.
No doubt there's other, possibly more elegant, ways of doing this, but this seems a simple enough solution.
That seems reasonable. Most of the YesLogic folks are on leave at the moment. We should be able to add this in the new year. I return 11 Jan, feel free to ping me at the end of that week if you haven't heard anything by then.
I've pushed a change to implement this. I hope to make a release this week but we've got a few other tweaks in the works that I'd like to include so will hold off for a day or so.
Thank you for such a useful crate! As currently implemented, the use of the
flate2/zlib
feature in Cargo.toml prevents compiling to WASM, since zlib is not available. Would it be possible to make this dependency optional? Something like the following would do it:The
flate2/zlib
feature is now exposed byallsorts/zlib
, which is added to the default features. So by default everything remains exactly the same. But now consumers who want to compile to WASM (or other scenarios where zlib is not available) can remove that feature and use theallsorts/miniz_oxide
feature instead.No doubt there's other, possibly more elegant, ways of doing this, but this seems a simple enough solution.
Possibly related to #7.
The text was updated successfully, but these errors were encountered: