Emit error if Allsorts is built without one of the flate2 features #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
For future reference this is what the errors look like:
|
|
Have you tested what happens when they are both enabled? It should just work then, right? |
Yes, flate2 builds ok. It appears to use zlib in that case |
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
If Allsorts is built without one of the flate2 features enabled emit a compile error with a message indicating this. The
flate2dependency is also marked optional so that in this case we a avoid a bunch of cryptic errors from trying to build that crate without a backend. There are still errors originating from Allsorts attempting to useflate2when it's not been pulled in but there's fewer of them and they're a bit more obviously tied to theflate2dependency.