Fix glyf loca null transform parsing #88
Conversation
There was a problem hiding this comment.
Well that's embarrassing on my part. Thanks for the issue and fix. One thing to resolve before merging is what is the provenance of the test font? In the fonts README we like to capture the source of fonts we include in the repo and their license. Or if it was hand made include a note in the woff2 README for how it was made.
|
This was merged manually: https://github.com/yeslogic/allsorts/compare/4d3a79d56dfa281070bbc567eedf67847c69b215..e96b0e272941da3a40659d2c727694c1d382eda5 Thanks again. |
|
@wezm about the provenance and licensing (thanks for your concern about that!): I built the test font with my own font builder, which is the font builder that builds all Font Awesome 6 fonts, including the Font Awesome 6 Free fonts, which are licensed under the SIL OFL 1.1 License. I used SVG sources for glyphs that are mostly from Font Awesome 5 Free, and one from Font Awesome 6 Free (itemized below). If you wanted a cleaner, less mixed provenance for a test font, with open-source-friendly licensing, I think you could use exactly this Solid Style Font Awesome 6 Free woff2 font. It would just be needlessly large, since it has lots of icons in it. I haven't tried it to be 100% sure, but since it would have built by the same font builder, I'm 99% sure that it would reproduce the original issue here in the same way. I just preferred using a smaller font as a test fixture to make it a closer-to-minimal reproduction of the bug. If there's a concern about how to possibility reproduce/rebuild this test font using the same font builder, that would not be directly available to an open source developer, since that font builder is Font Awesome's proprietary software. However, a Font Awesome Pro subscriber could achieve it by creating a kit with custom icon uploads that are just this same set of FA Free icons I used here, and then download the kit. The It doesn't matter much about the SVGs that were the sources of the glyphs in the test font, since what matters here is how the font tables were being encoded (regardless of the particular glyphs). But to account for the licensing of those raw materials used in the test font: The SVGs encoded as glyphs in the font are included from either Font Awesome 5 Free (license) (code points
|
Closes #87