-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webp use local directory when media set to cloudfront #173
Comments
What did you do to make sure Cloudfront was used in the first place? Because out-of-the-box, Magento only supports a different media URL and that media URL simply would apply to WebP images as well. In other words, you are probably overlooking that your Magento shop has some customization done already. |
Yes, Media URL set to https://d31m0372zcgus6.cloudfront.net/ whereas my site URL is https://www.generalapparel.org/ when media load in picture tag, it shows as below < picture class="product-image-photo"> |
It was working fine, issue came after I upgrade to new version. New Version Yireo NextGenImages Old Version Yireo NextGenImages |
I added following lines of code in function convertImage in vendor\yireo\magento2-webp2\Convertor\Convertor.php file at the end and return $webpImage and create setURL function in vendor\yireo\magento2-next-gen-images\Image\Image.php to update private attribute url
and output: < picture class="product-image-photo"> Note: this is private site only for development |
Hello, thanks @Khushpinder Your issues helped me quickly identify my problem. 👍 |
Did you try my solution? |
Hi @Khushpinder , |
When media is from cloudfront, webp not use the cloudfront url, it is getting from local directory
The text was updated successfully, but these errors were encountered: