Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Vertex Module in 2.4.1 #16

Closed
pauldonnelly opened this issue Oct 29, 2020 · 9 comments
Closed

Additional Vertex Module in 2.4.1 #16

pauldonnelly opened this issue Oct 29, 2020 · 9 comments

Comments

@pauldonnelly
Copy link

pauldonnelly commented Oct 29, 2020

Jisse, it looks like module-address-validation-api needs to be included along side the Vertex modules. When bin/magento s:up is ran it throws the following error:

PHP Fatal error: Interface 'Vertex\Data\AddressInterface' not found in ../vendor/vertex/module-address-validation-api/Api/Data/AddressInterface.php on line 18

I assume removing module-address-validation-api along with the other modules will fix this.

@jissereitsma
Copy link
Collaborator

jissereitsma commented Oct 30, 2020

Thanks for addressing this. In none of my environments, with or without this replacement used, I can find a package named vertex/module-address-validation-api. Is this the Magento Commerce edition you are referring to?

@jissereitsma
Copy link
Collaborator

Scrap that. It is simplythere in M2.4.1 CE. I'll add a commit to this. Please note that you are welcome to make PRs as well :) About the same amount of work: ec57d50

@jissereitsma
Copy link
Collaborator

https://github.com/yireo/magento2-replace-bundled/releases/tag/4.1.3

@Aquive
Copy link

Aquive commented Apr 15, 2021

What is the best way to use this tag? When I do composer require yireo/magento2-replace-bundled:^4.1 --no-update It doesn't get the packages with this fix.

@jissereitsma
Copy link
Collaborator

@Aquive If you are talking about the module vertex/module-address-validation-api, it is already included in the release 4.1.1 of this replacement package: https://github.com/yireo/magento2-replace-bundled/blob/4.1.4/composer.json#L35 Which exact version did you install and which packages are not replaced yet?

@Aquive
Copy link

Aquive commented Apr 15, 2021

@jissereitsma thanks for your swift reply. I am not so familiar with requiring a specific tag. I saw it was included in the 4.1.3 tag.

What is tried is both:

composer require yireo/magento2-replace-bundled:^4.0 --no-update
composer update --no-lock

and

composer require yireo/magento2-replace-bundled:^4.1 --no-update
composer update --no-lock

Magento version is 2.4.1 btw.

@jissereitsma
Copy link
Collaborator

If you run composer show yireo/magento2-replace-bundle, which version is reported? Likewise, which Vertex packages are still there? composer show | grep vertex

@Aquive
Copy link

Aquive commented Apr 16, 2021

I switched to a manual solution after some other problems. I would have liked to answer your question. But cannot anymore since I moved on. Thanks for the support!

@jissereitsma
Copy link
Collaborator

Ok, then I'll close this issue for now. Feel free to re-open if this problem still exists. Or open another issue for another problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants