Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some modules from replace-core should be here too #5

Closed
robbertstevens opened this issue Oct 28, 2019 · 3 comments
Closed

Some modules from replace-core should be here too #5

robbertstevens opened this issue Oct 28, 2019 · 3 comments

Comments

@robbertstevens
Copy link

Maybe we should add the following packages from magento2-replace-core in this one too:

  • "magento/module-fedex": "*",
  • "magento/module-eway": "*",
  • "magento/module-dhl": "*",
  • "magento/module-ups": "*",
  • "magento/module-worldpay": "*"
  • "magento/module-signifyd": "*",
  • "magento/google-shopping-ads": "*",
  • "magento/module-authorizenet": "*",
  • "magento/module-authorizenet-acceptjs": "*",
  • "magento/module-authorizenet-cardinal": "*",
  • "magento/module-authorizenet-graph-ql": "*",
  • "magento/module-cybersource": "*",
@lewisje
Copy link

lewisje commented Jan 29, 2020

It also looks like these modules, new to Magento 2.3.4, fit the pattern:

"magento/module-adobe-ims": "*",
"magento/module-adobe-ims-api": "*",
"magento/module-adobe-stock-admin-ui": "*",
"magento/module-adobe-stock-asset": "*",
"magento/module-adobe-stock-asset-api": "*",
"magento/module-adobe-stock-client": "*",
"magento/module-adobe-stock-client-api": "*",
"magento/module-adobe-stock-image": "*",
"magento/module-adobe-stock-image-admin-ui": "*",
"magento/module-adobe-stock-image-api": "*",

@jissereitsma
Copy link
Collaborator

Correct. Happy to see pull requests for this. Otherwise I will pick this up in 2 weeks time.

@jissereitsma
Copy link
Collaborator

@lewisje See https://github.com/yireo/magento2-replace-core/blob/magento-2.3.4/composer.json

@robbertstevens No, this wouldn't be a good idea. The magento2-replace-core package is meant to replace core features developed by Magento (which is Adobe), while the magento2-replace-bundled package is meant to replace third party extensions that are bundled with the core. You can install both packages though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants