Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for numpy 2.0 #56

Open
corentin-regent opened this issue Jun 19, 2024 · 1 comment · May be fixed by #57
Open

Add support for numpy 2.0 #56

corentin-regent opened this issue Jun 19, 2024 · 1 comment · May be fixed by #57

Comments

@corentin-regent
Copy link

Numpy 2.0 just dropped and came with changes that broke pandavro. When importing pandavro I now get the following error:

AttributeError: `np.unicode_` was removed in the NumPy 2.0 release. Use `np.str_` instead.

There might be other breaking changes affecting this package, I did not investigate it. The full numpy 2.0 release notes can be found here.
@fredcohen-aa
Copy link

It just needs an update in this dictionary. I was attempting to do this change in a forked repo but I'm finding the unit tests aren't really functional on windows so can't be that confident this doesn't have unintended consequences.

NUMPY_TO_AVRO_TYPES = {
..
    np.dtype('O'): 'complex',  # FIXME: Don't automatically store objects as strings
    np.str_: 'string',

This was referenced Jul 24, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support numpy 2.0 and pandas 2.0 aspeddro/pandavro
2 participants
@fredcohen-aa @corentin-regent