-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reevaluate inflection information styling #564
Comments
I would love to remake the inflection box feature for Yomitan, but I have no clue how to make it a togglable option. Let me know if you'd like something like that. |
Here's a mock-up. I changed the @toasted-nutbread @StefanVukovic99 How does this look? |
Looks ok, I like that it shows the original text before deinflection. However, I intentionally skipped that box when i was first integrating @seth-js's changes as i estimated it wasn't worth it.
|
In that case, I'll wait until |
Keep in mind that hover does not exist on touch screens, and a conditionally visible element like this is probably better suited for some sort of popup that is not inline in the document flow. I've also thought about this a few times and a few times I've wished that more information could be shown on the inflections; not by default, but by clicking on it to get more details or something. Basically, an option to allow the user to see every step of the deinflection process. I think this would also help debugging a lot of cases as the inflection logic becomes more broad and/or complex. |
I just saw @seth-js's PR #561 and thought this should be made into an issue since I raised the same concerns two days ago on TMW Discord.
I agree that the new styling takes up too much space. I think placing all of this information next to the headword looks fine:
But this styling collapses if there's too many inflection rules or the popup size is too small. It probably wouldn't look good for languages with a long list of inflections either:
Seth's forks actually hide this information by default to save space:
It might be my own personal preference towards more compact layouts, but I think the loss of vertical space pushing down the definitions (the main purpose of this extension) is a design issue. I understand the sentiment of leaving it to custom CSS, but I'm assuming the vast majority of users don't want to touch anything related to code, and want these sorts of things to either be the default or an option they can set.
The text was updated successfully, but these errors were encountered: