Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading User DAO SNS Canisters #421

Closed
7 tasks done
ravi-sawlani-yral opened this issue Oct 16, 2024 · 23 comments
Closed
7 tasks done

Upgrading User DAO SNS Canisters #421

ravi-sawlani-yral opened this issue Oct 16, 2024 · 23 comments
Assignees

Comments

@ravi-sawlani-yral
Copy link
Collaborator

ravi-sawlani-yral commented Oct 16, 2024

@ravi-sawlani-yral ravi-sawlani-yral self-assigned this Oct 16, 2024
@harshita-srivastava-yral
Copy link

harshita-srivastava-yral commented Oct 29, 2024

  • Canister upgrade is in faulty state and need to send the upgrade again
  • We should have a github action flow to check upgrade locally
  • Build the WASM from previous tech and then check the upgrade of individual canister

@harshita-srivastava-yral
  • SNS canister upgradation is facing challenge. It doesn't have version and its empty
  • To upgrade we need the version
  • Get running SNS version is responding "None" on version check
  • We might have to upgrade each canister individually.
  • For old cansiter check which users data we need to keep

@harshita-srivastava-yral
  • We need to update the same version with correct params this time. Proposed solution.
  • Try running the SNS version with the correct version mentioned and check if its running now.

@harshita-srivastava-yral
Copy link

harshita-srivastava-yral commented Nov 6, 2024

  • Trying to make the previous canisters work
  • We might loose user data
  • API is not going to accept the custom values (To be part of this upgradation scope)
  • Make the advanced setting fields read only for users (Frontend work @harshita-srivastava-yral to assign it to dev)
  • We are going ahead with this and expectation is:
  1. All DOLR, USDC tokens will be there
  2. All the tokens which I as a user has created will be there (100% supply will be there)
  3. All the tokens sent to me by some other user will be deleted

@ravi-sawlani-yral Once deployed please inform us we will test this out

@harshita-srivastava-yral

@harshita-srivastava-yral
  • We will send the upgrade today.
  • We will need cycled (500 trillion we have as of now)
  • Approx. - 0.1 Trillion per token (20,000 trillion for now)
  • Some cycles required for making empty canisters as well.

@harshita-srivastava-yral
  • Raised the Pr and testing it locally by creating the token.
  • New version and old version has changes which need to be tested.
  • We will try to close it today

@harshita-srivastava-yral
  • Token creation will be now switched to new SNS version
  • We have moved everything to questash
  • Raised the PR for stopping backup canister

@harshita-srivastava-yral
  • Cost of cycle is high if we give everyone cycle and then upgrade
  • There are lot of redundant tokens in the system
  • When we delete a canister, canister ID is not removed from the routing canister...we can then reuse that ID to install code on that canister.
  • 2 clear UCs where we can save cost: Never logged in, not processed tokens (Invalid deployment)

This is going to be 4 step process:

  • Delete all canisters for never logged in users

  • Delete all canisters of users whose deployment was invalid

  • Logged in user with no transaction history, pulling SNS meta info deleting canister installing the version on those canister then recreating the canister for them and deploying it back

  • If token has transaction, then we need to do full fat installations for them @ravi-sawlani-yral to check this and comeback

  • Way forward to save cost:

    • Limit the number of tokens per user canister can create on platform (maybe limit to 2 from 5)
    • Fast follower of this can be - First is trial token, and second token needs to have DOLR balance and will not be free for users to create on the platform
    • User side announcement - If non logged in users, log in with the google account which has not been registered with Yral earlier can claim the tokens in the google account canister

@harshita-srivastava-yral
  • We will need cycle 150k trillion cycle which requires discussion with @saikatdas0790
  • To be closed today

@saikatdas0790
Copy link
Contributor

  • We will need cycle 150k trillion cycle which requires discussion with @saikatdas0790
  • To be closed today

Round 1 of discussions and takeaways documented here:
#463

@harshita-srivastava-yral
  • Cycle optimisation needs to be worked on
  • Need a new version of pocket IC and its not working
  • Blocked in ICP end
  • Raised a forum post.

@harshita-srivastava-yral
  • Current changes have not been put
  • Only way to test it is mainet..
  • There are risks associated with this wherein the app might not work for like 8 hrs if upgradation doesn't propoerly go through

@harshita-srivastava-yral
  • ICP has responded and we are testing the new IC pocket update
  • There are issues related to new HON game
  • Testing the flow and if it gets fixed then we can deploy today

@harshita-srivastava-yral
Copy link

harshita-srivastava-yral commented Dec 2, 2024

  • Anonymous users all tokens will be deleted - Will be closed today
  • We will also need to delete it from firebase and big query
  • Once all user are on latest version then we can pin it and push other changes
  • Post these, we will also need to delete the invalid tokens - Next Step

@harshita-srivastava-yral
  • All the anonymous tokens have been deleted.
  • Follow up tasks for this has been created in a new issue
  • By tomorrow, this should be closed

@harshita-srivastava-yral
  • Upgrade part is done

@harshita-srivastava-yral
  • The WASM pulled from github was not supposed to be done
  • There are no module hash for older canister
  • @ravi-sawlani-yral to check with team

@harshita-srivastava-yral
  • Today evening we will have all the SNS canister with the latest version

@harshita-srivastava-yral
  • Offchain agent is down hence not able to close this yet
  • EOW all the canister should be on latest version and upgraded

@harshita-srivastava-yral
  • Some of the upgrade has been done
  • There are few errors which are being tested which are mostly due to offchain

@harshita-srivastava-yral
  • Migrate all the SNS canister to latest version
  • The current version already has all dependencies resolved hence no blocker.

@harshita-srivastava-yral
  • Latest version PR needs to be reviewed by @rupansh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants