Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom domain being overwriten #6

Open
arafai opened this issue Oct 18, 2023 · 1 comment
Open

Custom domain being overwriten #6

arafai opened this issue Oct 18, 2023 · 1 comment

Comments

@arafai
Copy link

arafai commented Oct 18, 2023

hi @yurikoval,

Firstly, thanks for creating and maintaining the Github action, it's very useful, thank you!

I was wondering if you'd be open to adding another feature: custom domain.
I set the custom domain on the Settings page but each time when it gets deployed, it gets overwritten.

The following would be required:

  • add another parameter to the Github Action, CUSTOM_DOMAIN where the user can add his custom domain ( eg: api.mydomain.com)
  • if CUSTOM_DOMAIN param is set, create a file named CNAME in the root directory with the CUSTOM_DOMAIN value as a single line (api.mydomain.com)

What do you think?

Kind regards,
Andrei

@arafai arafai changed the title Custom domain being overwritten Custom domain being overwriten Oct 18, 2023
@arafai
Copy link
Author

arafai commented Oct 18, 2023

@yurikoval I've created a PR, please review: #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant