Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Final Song on Sleep Timer #1806

Open
3 tasks done
Shinhok-NGL19 opened this issue Feb 6, 2025 · 0 comments
Open
3 tasks done

Finish Final Song on Sleep Timer #1806

Shinhok-NGL19 opened this issue Feb 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@Shinhok-NGL19
Copy link

Checklist

  • I've checked that there is no other issue about this feature request.
  • This issue contains only one feature request.
  • The title of this issue accurately describes the feature request.

Feature description

So there's this one little (probably niche) feature that would be really nice if implemented.

Basically, when a sleep timer of a certain duration is enabled, when it ends, the playback immediately stops. It stops even if it was in the middle of the song.

My suggestion would be to add a toggle Finish Final Song on Timer in Player Settings. When this is enabled, the app checks when the timer is about to expire, and adds another End of the Song timer to ensure the last song is finished and then the player smoothly stops playing.

Why do you want this feature?

This will prevent songs from abruptly ending after the timer finished and will allow the song to be fully played out before the player stops.

Those who do not wish this and want their playback to be immediately stopped when timer reaches 0 can opt to turn off this setting, and it can stay Off by default.

Additional information

I'm not well versed with the developmental side of things. But I'm imagining it to work this way:

  1. The option is enabled in Player Settings
  2. A timer of a certain duration (NOT End of Song) is placed
  3. The app places another End of The Song timer automatically when the set timer reaches 0, without stopping the playback.
  4. If the remaining duration of the End of The Song timer can be rounded down to 0, no timer is placed. (If this one needs extra work then the player can always set the timer no matter what, it doesn't really matter I believe)
@Shinhok-NGL19 Shinhok-NGL19 added the enhancement New feature or request label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant