Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip package #59

Open
skull-squadron opened this issue Oct 30, 2024 · 3 comments
Open

Make pip package #59

skull-squadron opened this issue Oct 30, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@skull-squadron
Copy link

If this were a pypi package, it could be installed simply as a CLI tool with pipx install qr-backup. No need to have a clunky build system or manually install anything.

@za3k za3k changed the title Yo Make pip package Oct 30, 2024
@za3k za3k added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 30, 2024
@za3k
Copy link
Owner

za3k commented Oct 30, 2024

That's not entirely true, because it has a lot of command-line dependencies, but it would be an improvement.

Want to offer a patch?

@Jelloeater
Copy link

Maybe even a simple bash script to install the deps?
https://github.com/za3k/qr-backup/blob/master/docs/INSTALL.md#dependencies

I've also used https://www.pyinvoke.org as well for complex build scripts, works really well when you need more than something like Make or https://taskfile.dev

@za3k
Copy link
Owner

za3k commented Nov 1, 2024

There essentially is a bash script, although it could be expanded per-distro to be more complete: https://github.com/za3k/qr-backup/blob/master/docs/INSTALL.md#other-linux-bsd
If you would like to update CLI install for a particular distro, or fix for modern python packaging by putting in a venv, feel free to offer doc patches. I would be happy to accept them.

There is no build script. I wonder if you've misunderstood something? qr-backup is a single python file.

The Makefile only builds the debian package, so it only needs to be run by me. It's not used to generate a binary.

@skull-squadron skull-squadron closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
@za3k za3k reopened this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants