Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vetoes from the PR author #21

Open
nolar opened this issue Mar 27, 2019 · 2 comments
Open

Vetoes from the PR author #21

nolar opened this issue Mar 27, 2019 · 2 comments

Comments

@nolar
Copy link

nolar commented Mar 27, 2019

As an author of a PR,
I want (sometimes) to put a veto on it,
So that it would not be merged by other maintainers until some clarification is achieved.

With Zappr, it is done by putting a thumb-down (👎 ) to the comments. In Zincr & GHE, the author cannot block the PR by "Requesting the changes".

As one way (but not necessary the best), a config could be added to .zappr.yaml to block by existence of a label would be good (e.g. "WIP" label, or "on-hold" label).

@perploug
Copy link
Contributor

perploug commented Apr 1, 2019

Ah, so the author you want to block it - was womderig why request-changes wasn't enough for this - wouldn't the Draft state for the PR solve this - or does that come with other issues?

@nolar
Copy link
Author

nolar commented Apr 12, 2019

Yes, it seems, it helps to achieve the goal of vetoing the PR by its author. Zincr still reacts to these PR drafts, but this is fine (Travis also does react). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants