Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Docker/Unix Idioms and Security. #106

Open
iMerica opened this issue Jun 23, 2018 · 0 comments
Open

Docker/Unix Idioms and Security. #106

iMerica opened this issue Jun 23, 2018 · 0 comments

Comments

@iMerica
Copy link

iMerica commented Jun 23, 2018

Hi, thanks for putting this together. Just a few feedback items to consider:

  • Eschew bash wrappers over docker and docker-compose (especially curl to bash ). Responsible users will have to read every line of the bash script before running it anyway. Which is a waste since everything this script does can already be done with plain old Docker or Compose. It would be better to just prepare a ready made docker-compose.yml file that can be copy/pasted and just run TARGET_HOST=example.com docker-compose up -d to run the entire stack.
  • The image URL in the README is not hosted in Docker hub. This is concerning from a security POV since we now have to trust an unknown third party container registry to use it. Whereas on Docker Hub, we have community ratings, security scanning etc.
  • Make it clear why AWS credentials are needed (-v ~/.aws:/root/.aws) to run a single instance of the stack. It currently doesn't seem required to run this locally yet the aws credentials are volume mounted in all the examples.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant