Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context canceled error when collecting metrics from thanos-querier #747

Open
LeonD9 opened this issue Aug 15, 2024 · 1 comment
Open

context canceled error when collecting metrics from thanos-querier #747

LeonD9 opened this issue Aug 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@LeonD9
Copy link

LeonD9 commented Aug 15, 2024

Expected Behavior

No errors in log of kube-metrics-adapter

Actual Behavior

I receive the following error after the collector runner is stopped for connecting to the thanos-querier:

time="2024-08-15T11:20:33Z" level=info msg="stopping collector runner..."
time="2024-08-15T11:20:33Z" level=error msg="Failed to collect metrics: Post \"http://thanos-querier.kube-system.svc.cluster.local:10902/api/v1/query\": context canceled" provider=hpa

Is this ERROR expected? it happens frequently but i didn't see any impact on HPA, what can i do to resolve it?

Steps to Reproduce the Problem

Upgrade from v0.1.8 to v0.2.3, i didn't see this kind of error messages in v0.1.8 but i started seeing them after i upgraded to v0.2.3
Run kube-metrics-adapter with --prometheus-server=http://thanos-querier.kube-system.svc.cluster.local:10902 arg

Specifications

Latest image version: ghcr.io/zalando-incubator/kube-metrics-adapter:v0.2.3
EKS: v1.24

@mikkeloscar
Copy link
Contributor

This has likely been introduced with: #713

The collectors are stopped when the HPA is changing and the context is cancelled.

This should not have an impact on the functionality, but I agree it's a bit confusing to have such logs.

@mikkeloscar mikkeloscar added the bug Something isn't working label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants