Fix the check for HPA changed #785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
added
the
bugfix
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics-adapter continuously checks for changes between the cached HPAs and HPAs in the cluster to detect potential changes.
The logic for checking if a cached HPA is up-to-date is broken because Metadata of an HPA, e.g. managedFields can change without the actual HPA spec changes which would require a change on the metric collector.
Fix this by only comparing HPA annotations and Spec as those are the only things that matter for comparing HPAs and deciding if the collector should be re-initialized.
Additionally change some logging to be debug logging to reduce noise if nothing changes for a while.
Fix #774