Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-zero weights: is it allowed and how is traffic distributed #43

Open
linki opened this issue Sep 3, 2018 · 1 comment
Open

All-zero weights: is it allowed and how is traffic distributed #43

linki opened this issue Sep 3, 2018 · 1 comment

Comments

@linki
Copy link
Member

linki commented Sep 3, 2018

There is unclarity how an all-zero traffic weight is handled and interpreted.

Handled (currently):

  • rejected by at least one client (zkubectl)
  • Not handled by the server (stackset controller allows this setting)

Interpretation (currently)

  • stackset-controller resolves all-zero weights to equal traffic distribution
    • this seems undesireable by a majority of users at the moment

Clarify what's the desired behaviour:

  • Should all-zero weights be possible at all
    • where to make the validation and reject the request?
  • How to interpret all-zero weights if allowed
    • equal distribution or zero traffic
@linki linki changed the title All weights zero: traffic is equally distributed All-zero weights: allowed and how is traffic distributed Sep 3, 2018
@linki linki changed the title All-zero weights: allowed and how is traffic distributed All-zero weights: is it allowed and how is traffic distributed Sep 3, 2018
@szuecs
Copy link
Member

szuecs commented Sep 4, 2018

What does reject the request mean?
Maybe 404?
What if we have routes / and /api and traffic to /api will be set to 0 for all. The http routing tree will probably delete the route and will send the traffic to the routes for /, which might not be what the user thought "all 0" means.

The longer I think about this case the more I think we should disallow this setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants