-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing way to add annotations to deployment #69
Comments
That annotation is added at the pod level i.e. the podTemplate part of the spec. Example: apiVersion: zalando.org/v1
kind: StackSet
metadata:
name: my-app
spec:
ingress:
hosts: [my-app.example.org, alt.name.org]
backendPort: 80
stackLifecycle:
scaledownTTLSeconds: 300
limit: 5
stackTemplate:
spec:
version: v1
replicas: 3
podTemplate:
metadata:
annotations:
kubernetes-log-watcher/scalyr-parser: '[{"container": "nginx", "parser": "my-parser"}]'
spec:
containers:
- name: nginx
image: nginx
ports:
- containerPort: 80
name: ingress |
Thanks a lot, I will try 😄 |
Hi, now we really need to add a annotation on deployment level. Is there any way to do it? |
Not right now, what is the use case? :) |
Our SRE added a custom scaleup/scaledown annotation that is currently only supported at deployments. I asked to move it to the service itself but he argumented that the ReplicaSet is actually owned by the deployment therefor the annotation should belong to the deployment and not service. |
As discussed in private this use case might not be solved by allowing specifying annotations on deployments. Rather the annotations should be on the stacks and the tool which rely on the annotation should operate on stacks instead of deployments. |
@mikkeloscar we have the same with docker-meta in our test cluster that we need for e2e image webhook tests. |
Hi,
I couldn't find a way to add annotations to a deployment. For service, ingress and even pods it's straight forward. The annotation is at Zalando to define a custom log parsers for Scalyr.
Maybe I just missed the way to achieve it.
The text was updated successfully, but these errors were encountered: