Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Missing error processing in ControllerProxy #68

Open
1 task
elgris opened this issue Aug 22, 2017 · 0 comments
Open
1 task

Missing error processing in ControllerProxy #68

elgris opened this issue Aug 22, 2017 · 0 comments
Labels
bug user-reported issues that take more than one hour to resolve Java Revisit Relevant issue. Needs to be tackled as part of current stabilising work

Comments

@elgris
Copy link
Contributor

elgris commented Aug 22, 2017

How to reproduce

  1. Install whole ZMON stack
  2. Break ZMON Controller API so it returns errors (e.g. because of broken auth configuration, so requests from data-service are not authorised)
  3. Observe Index Out of Bounds Exception coming from de.zalando.zmon.dataservice.proxies.ControllerProxy#proxyForLastModifiedHeader

Explanation

When ZMON Controller API returns error responses, data-service still tries to get "Last-Modified" header from there and fails. Need to make sure that data-service tries to check if the header in the response before it tries to extract it.

Acceptance criteria

  • Instead of Out of Bounds Exception data-service must report that "Last-Modified" header was not found and provide response data, so it's easier for developers to investigate
@elgris elgris added the bug user-reported issues that take more than one hour to resolve label Aug 22, 2017
@rajatparida86 rajatparida86 added the Revisit Relevant issue. Needs to be tackled as part of current stabilising work label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug user-reported issues that take more than one hour to resolve Java Revisit Relevant issue. Needs to be tackled as part of current stabilising work
Projects
None yet
Development

No branches or pull requests

3 participants