From a985047516091996f337fc76026b8bc2084ae1b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Test=C3=A9?= Date: Fri, 7 Feb 2025 14:56:14 +0100 Subject: [PATCH] chore(ci): always run should-run step against base commit Running against last remote commit would induce undesired behavior, especially on pull-request approval. For example a change in integer layer could occur in the pull-request commits list but the changes aren't contained in the last remote commit. Then, on approval, aws_tfhe_integer_tests.yml workflow would be skipped although it should run regarding the base commit. --- .github/workflows/aws_tfhe_fast_tests.yml | 1 - .github/workflows/aws_tfhe_integer_tests.yml | 1 - .github/workflows/aws_tfhe_signed_integer_tests.yml | 1 - .github/workflows/aws_tfhe_tests.yml | 1 - .github/workflows/benchmark_tfhe_zk_pok.yml | 1 - .github/workflows/benchmark_wasm_client.yml | 1 - .github/workflows/benchmark_zk_pke.yml | 1 - .github/workflows/check_ci_files_change.yml | 1 - .github/workflows/gpu_fast_h100_tests.yml | 1 - .github/workflows/gpu_fast_tests.yml | 1 - .github/workflows/gpu_full_multi_gpu_tests.yml | 1 - .github/workflows/gpu_signed_integer_classic_tests.yml | 1 - .github/workflows/gpu_signed_integer_h100_tests.yml | 1 - .github/workflows/gpu_signed_integer_tests.yml | 1 - .github/workflows/gpu_unsigned_integer_classic_tests.yml | 1 - .github/workflows/gpu_unsigned_integer_h100_tests.yml | 1 - .github/workflows/gpu_unsigned_integer_tests.yml | 1 - 17 files changed, 17 deletions(-) diff --git a/.github/workflows/aws_tfhe_fast_tests.yml b/.github/workflows/aws_tfhe_fast_tests.yml index a69f540636..0a0da96ccb 100644 --- a/.github/workflows/aws_tfhe_fast_tests.yml +++ b/.github/workflows/aws_tfhe_fast_tests.yml @@ -76,7 +76,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | dependencies: - tfhe/Cargo.toml diff --git a/.github/workflows/aws_tfhe_integer_tests.yml b/.github/workflows/aws_tfhe_integer_tests.yml index ef17a1d0fc..45608740c1 100644 --- a/.github/workflows/aws_tfhe_integer_tests.yml +++ b/.github/workflows/aws_tfhe_integer_tests.yml @@ -64,7 +64,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | integer: - tfhe/Cargo.toml diff --git a/.github/workflows/aws_tfhe_signed_integer_tests.yml b/.github/workflows/aws_tfhe_signed_integer_tests.yml index 981e99804a..d9a009b22d 100644 --- a/.github/workflows/aws_tfhe_signed_integer_tests.yml +++ b/.github/workflows/aws_tfhe_signed_integer_tests.yml @@ -65,7 +65,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | integer: - tfhe/Cargo.toml diff --git a/.github/workflows/aws_tfhe_tests.yml b/.github/workflows/aws_tfhe_tests.yml index 6dbbd215d3..4b1a304528 100644 --- a/.github/workflows/aws_tfhe_tests.yml +++ b/.github/workflows/aws_tfhe_tests.yml @@ -86,7 +86,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | dependencies: - tfhe/Cargo.toml diff --git a/.github/workflows/benchmark_tfhe_zk_pok.yml b/.github/workflows/benchmark_tfhe_zk_pok.yml index 049b422624..db3f89c60d 100644 --- a/.github/workflows/benchmark_tfhe_zk_pok.yml +++ b/.github/workflows/benchmark_tfhe_zk_pok.yml @@ -38,7 +38,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | zk_pok: - tfhe-zk-pok/** diff --git a/.github/workflows/benchmark_wasm_client.yml b/.github/workflows/benchmark_wasm_client.yml index 3cf984d607..e0bda6adc4 100644 --- a/.github/workflows/benchmark_wasm_client.yml +++ b/.github/workflows/benchmark_wasm_client.yml @@ -43,7 +43,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | wasm_bench: - tfhe/Cargo.toml diff --git a/.github/workflows/benchmark_zk_pke.yml b/.github/workflows/benchmark_zk_pke.yml index 9805c4efbc..5c2ff3240e 100644 --- a/.github/workflows/benchmark_zk_pke.yml +++ b/.github/workflows/benchmark_zk_pke.yml @@ -50,7 +50,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | zk_pok: - tfhe/Cargo.toml diff --git a/.github/workflows/check_ci_files_change.yml b/.github/workflows/check_ci_files_change.yml index 2ad56cb65f..d3b93f0873 100644 --- a/.github/workflows/check_ci_files_change.yml +++ b/.github/workflows/check_ci_files_change.yml @@ -34,7 +34,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | ci: - .github/** diff --git a/.github/workflows/gpu_fast_h100_tests.yml b/.github/workflows/gpu_fast_h100_tests.yml index 30ea0b1377..61a96c016a 100644 --- a/.github/workflows/gpu_fast_h100_tests.yml +++ b/.github/workflows/gpu_fast_h100_tests.yml @@ -54,7 +54,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_fast_tests.yml b/.github/workflows/gpu_fast_tests.yml index f917025405..792e17abe1 100644 --- a/.github/workflows/gpu_fast_tests.yml +++ b/.github/workflows/gpu_fast_tests.yml @@ -52,7 +52,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_full_multi_gpu_tests.yml b/.github/workflows/gpu_full_multi_gpu_tests.yml index 59c524f3c8..1cae90c70b 100644 --- a/.github/workflows/gpu_full_multi_gpu_tests.yml +++ b/.github/workflows/gpu_full_multi_gpu_tests.yml @@ -54,7 +54,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_signed_integer_classic_tests.yml b/.github/workflows/gpu_signed_integer_classic_tests.yml index 8727e29d79..4d632561e6 100644 --- a/.github/workflows/gpu_signed_integer_classic_tests.yml +++ b/.github/workflows/gpu_signed_integer_classic_tests.yml @@ -54,7 +54,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_signed_integer_h100_tests.yml b/.github/workflows/gpu_signed_integer_h100_tests.yml index 75e19aaeb0..2f4ea586cf 100644 --- a/.github/workflows/gpu_signed_integer_h100_tests.yml +++ b/.github/workflows/gpu_signed_integer_h100_tests.yml @@ -54,7 +54,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_signed_integer_tests.yml b/.github/workflows/gpu_signed_integer_tests.yml index aed2545f14..676abda766 100644 --- a/.github/workflows/gpu_signed_integer_tests.yml +++ b/.github/workflows/gpu_signed_integer_tests.yml @@ -57,7 +57,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_unsigned_integer_classic_tests.yml b/.github/workflows/gpu_unsigned_integer_classic_tests.yml index d134e15a3b..b50788d8fc 100644 --- a/.github/workflows/gpu_unsigned_integer_classic_tests.yml +++ b/.github/workflows/gpu_unsigned_integer_classic_tests.yml @@ -54,7 +54,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_unsigned_integer_h100_tests.yml b/.github/workflows/gpu_unsigned_integer_h100_tests.yml index f74b9d3e2a..a8d3921e17 100644 --- a/.github/workflows/gpu_unsigned_integer_h100_tests.yml +++ b/.github/workflows/gpu_unsigned_integer_h100_tests.yml @@ -54,7 +54,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml diff --git a/.github/workflows/gpu_unsigned_integer_tests.yml b/.github/workflows/gpu_unsigned_integer_tests.yml index b8f46d2167..c799646140 100644 --- a/.github/workflows/gpu_unsigned_integer_tests.yml +++ b/.github/workflows/gpu_unsigned_integer_tests.yml @@ -58,7 +58,6 @@ jobs: id: changed-files uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f with: - since_last_remote_commit: true files_yaml: | gpu: - tfhe/Cargo.toml