New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercase nibble in commands_hpsu.csv #14

Open

segaura opened this issue Apr 8, 2018 · 1 comment

segaura commented Apr 8, 2018

In HPSU.py the logic on "commands" require them to be defined with all nibble uppercase (e.g. if command[6:8] != "FA").

the file etc/pyHPSU/commands_hpsu.csv has a last row with some lowercase nibble

t_flow_cooling;61 00 fa 03 dd 00 00;190;d;10;w

this should be

t_flow_cooling;61 00 FA 03 DD 00 00;190;d;10;w

The text was updated successfully, but these errors were encountered:

Contributor

Spanni26 commented Apr 8, 2018

Thats a quick fix. But I would also add a ".upper()" at HPSU.py where it is needed.
Will add it at the next pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment