Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demjson dependance breaks install #5

Closed
vault1337 opened this issue Dec 22, 2021 · 7 comments
Closed

demjson dependance breaks install #5

vault1337 opened this issue Dec 22, 2021 · 7 comments
Labels
bug Something isn't working waiting Can not be fixed right now

Comments

@vault1337
Copy link

From Python 3.10, the dependent JSON package demjson fails to install.
Since stock JSON package exists and maintenance of dependent package is problematic (dmeranda/demjson#40) changing from demjson to builtin JSON would be favorable.

@rodja
Copy link
Member

rodja commented Dec 23, 2021

Yes, this dependency should be removed. Unfortunately it comes from JustPy. So we can not do anything but wait for @elimintz to fix justpy-org/justpy#301.

@elimintz
Copy link

I need to find time to release a new version with this. There is a demjson compatible package called demjson3 that solves this issue. If you want to fix it locally, change all import demjson lines to import demjson3 as demjson.
And you need to install demjson3.
The advantage of using demjson is that it can parse correctly javascript objects where the keys do not need to be between quotes.

@rodja rodja added bug Something isn't working waiting Can not be fixed right now labels Jan 10, 2022
@themerius
Copy link

it is also not installable with python 3.9.9, it will output this error:

error in demjson setup command: use_2to3 is invalid.

on python 3.8 it is installable.

@rodja rodja changed the title Dependent package breaks install demjson dependance breaks install Jan 18, 2022
@rodja
Copy link
Member

rodja commented Jan 18, 2022

You can try downgrading setuptools to 57.4.0. This is what we do in our continuous testing script:

pip3 install setuptools==57.4.0 # to fix https://github.com/elimintz/justpy/issues/301

@rodja rodja pinned this issue Jan 18, 2022
@themerius
Copy link

this workaround solves the issue. thanks! :)

@elimintz
Copy link

Version 0.2.3 of justpy which I released a few days ago should solve this problem. demjson was replaced with demjson3 so things should work fine now also without the workaround. Please let me know if this is not the case.

@rodja
Copy link
Member

rodja commented Feb 5, 2022

With release 0.7.6 we upgraded to JustPy 0.2.3. @elimintz thanks for fixing this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting Can not be fixed right now
Projects
None yet
Development

No branches or pull requests

4 participants