Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Fix off-by-one in scan estimation start height #945

Closed
nuttycom opened this issue Sep 6, 2023 · 2 comments
Closed

zcash_client_sqlite: Fix off-by-one in scan estimation start height #945

nuttycom opened this issue Sep 6, 2023 · 2 comments

Comments

@nuttycom
Copy link
Contributor

nuttycom commented Sep 6, 2023

Nit: now that start_height = birthday_height there's an off-by-one here, because the birthday height is one of the blocks that gets scanned, not the base block.

Non-blocking, the error in the output is minimal, and it isn't worth re-running CI.

Originally posted by @str4d in #944 (comment)
@nuttycom nuttycom added this to the SDK 2.0 Post-Release Cleanup milestone Sep 9, 2023
@daira
Copy link
Contributor

daira commented Oct 30, 2023

This only has a small effect on the progress measurement.

@nuttycom
Copy link
Contributor Author

nuttycom commented Oct 24, 2024 •
edited
Loading

Fixed by #1564 and #1541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nuttycom @daira