Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightwalletd does not parse zebrad.toml #462

Closed
hhanh00 opened this issue Oct 26, 2023 · 5 comments · Fixed by #485
Closed

lightwalletd does not parse zebrad.toml #462

hhanh00 opened this issue Oct 26, 2023 · 5 comments · Fixed by #485
Labels
bug Something isn't working

Comments

@hhanh00
Copy link

hhanh00 commented Oct 26, 2023

What is the bug?

[hanh@archlinux lightwalletd]$ lightwalletd --zcash-conf-path ~/.config/zebrad.toml --no-tls-very-insecure --log-file /dev/stdout
{"app":"lightwalletd","buildDate":"","buildUser":"","gitCommit":"","level":"info","msg":"Starting gRPC server version v0.0.0.0-dev on 127.0.0.1:9067","time":"2023-10-26T11:18:19+08:00"}
{"app":"lightwalletd","level":"warning","msg":"Starting insecure no-TLS (plaintext) server","time":"2023-10-26T11:18:19+08:00"}
Starting insecure server
{"app":"lightwalletd","error":"failed to read config file: key-value delimiter not found: \"dnsseed.z.cash:8233\",\n","level":"fatal","msg":"setting up RPC connection to zcashd","time":"2023-10-26T11:18:19+08:00"}
Lightwalletd died with a Fatal error. Check logfile for details.

zebrad.toml was generated by using zebra generate. It passes validation from https://www.toml-lint.com/

Additional context

Offending part of zebrad.toml

initial_mainnet_peers = [
    "dnsseed.z.cash:8233",
    "dnsseed.str4d.xyz:8233",
    "mainnet.seeder.zfnd.org:8233",
    "mainnet.is.yolo.money:8233",
]
@hhanh00 hhanh00 added the bug Something isn't working label Oct 26, 2023
@conradoplg
Copy link

lightwalletd doesn't support the zebra config file format. You will need to create a "fake" zcash.conf with the zcashd format with the information required. Some information here https://zebra.zfnd.org/user/lightwalletd.html#sync-lightwalletd

@hhanh00
Copy link
Author

hhanh00 commented Oct 26, 2023 via email

@LarryRuane
Copy link
Collaborator

I wasn't aware of this, would it be helpful if lightwalletd did support the zebrad.toml file format? That seems reasonable; I could make that code change if it would be helpful. And probably not that difficult as a toml parser library probably already exists.

@arya2
Copy link

arya2 commented Apr 15, 2024

I wasn't aware of this, would it be helpful if lightwalletd did support the zebrad.toml file format? That seems reasonable; I could make that code change if it would be helpful. And probably not that difficult as a toml parser library probably already exists.

I think this would be convenient if you could make that change.

LarryRuane pushed a commit to LarryRuane/lightwalletd that referenced this issue May 10, 2024
Fixes zcash#462. If the file extension is .conf (as in zcash.conf), then
parse the file as an INI file. If the extension is .toml (as in
zebrad.toml), then interpret as TOML.
@LarryRuane
Copy link
Collaborator

If any of you could test #485 that would be helpful; I'm not set up to run zebrad. The logic is pretty simple so it should work the first time.

LarryRuane pushed a commit to LarryRuane/lightwalletd that referenced this issue May 10, 2024
Fixes zcash#462. If the file extension is .conf (as in zcash.conf), then
parse the file as an INI file. If the extension is .toml (as in
zebrad.toml), then interpret as TOML.
LarryRuane pushed a commit to LarryRuane/lightwalletd that referenced this issue Jun 27, 2024
Fixes zcash#462. If the file extension is .conf (as in zcash.conf), then
parse the file as an INI file. If the extension is .toml (as in
zebrad.toml), then interpret as TOML.
LarryRuane pushed a commit to LarryRuane/lightwalletd that referenced this issue Jun 27, 2024
Fixes zcash#462. If the file extension is .conf (as in zcash.conf), then
parse the file as an INI file. If the extension is .toml (as in
zebrad.toml), then interpret as TOML.
LarryRuane pushed a commit to LarryRuane/lightwalletd that referenced this issue Jun 27, 2024
Fixes zcash#462. If the file extension is .conf (as in zcash.conf), then
parse the file as an INI file. If the extension is .toml (as in
zebrad.toml), then interpret as TOML.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants