AttributeSet report invalid locations
#1893
Assignees
Labels
Comments
evantypanski
added a commit
that referenced
this issue
Oct 17, 2024
Closes #1893 When a child is added with `addChild`, the parent's location should (generally) span over that child as well. This primarily helps for cases where a node doesn't have much of a location until it gets children added - like `AttributeSet`. The locations for those should encompass all of the attributes within the set. That logic applies for any node with a child: if it's the child, then its location should reflect that.
evantypanski
added a commit
that referenced
this issue
Oct 17, 2024
Closes #1893 When a child is added with `addChild`, the parent's location should (generally) span over that child as well. This primarily helps for cases where a node doesn't have much of a location until it gets children added - like `AttributeSet`. The locations for those should encompass all of the attributes within the set. That logic applies for any node with a child: if it's the child, then its location should reflect that.
evantypanski
added a commit
that referenced
this issue
Oct 17, 2024
Closes #1893 When a child is added with `addChild`, the parent's location should (generally) span over that child as well. This primarily helps for cases where a node doesn't have much of a location until it gets children added - like `AttributeSet`. The locations for those should encompass all of the attributes within the set. That logic applies for any node with a child: if it's the child, then its location should reflect that.
evantypanski
added a commit
that referenced
this issue
Oct 18, 2024
Closes #1893 When a child is added with `addChild`, the parent's location should (generally) span over that child as well. This primarily helps for cases where a node doesn't have much of a location until it gets children added - like `AttributeSet`. The locations for those should encompass all of the attributes within the set. That logic applies for any node with a child: if it's the child, then its location should reflect that.
evantypanski
added a commit
that referenced
this issue
Oct 18, 2024
Closes #1893 When a child is added with `addChild`, the parent's location should (generally) span over that child as well. This primarily helps for cases where a node doesn't have much of a location until it gets children added - like `AttributeSet`. The locations for those should encompass all of the attributes within the set. That logic applies for any node with a child: if it's the child, then its location should reflect that.
evantypanski
added a commit
that referenced
this issue
Oct 18, 2024
Closes #1893 When a child is added with `addChild`, the parent's location should (generally) span over that child as well. This primarily helps for cases where a node doesn't have much of a location until it gets children added - like `AttributeSet`. The locations for those should encompass all of the attributes within the set. That logic applies for any node with a child: if it's the child, then its location should reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Followup from #1890
Using the
AttributeSetin a diagnostic gets the following output:Where the locations are wrong (see:
11:17-11:16). The location of theAttributeSetshould encompass all of its children, I think. I'd ideally put this inaddChildfor the node, so any children expand a node's location, but that may have some other consequences.The text was updated successfully, but these errors were encountered: