Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option to Disable Automatic Update Check #6

Open
Vinetos opened this issue Oct 12, 2024 · 1 comment
Open

Feature Request: Option to Disable Automatic Update Check #6

Vinetos opened this issue Oct 12, 2024 · 1 comment

Comments

@Vinetos
Copy link

Vinetos commented Oct 12, 2024

Hey !

I wanted to propose a feature that could benefit users, particularly those using Nix: an option to disable the automatic update check in the custom browser.

For users building Firefox forks with Nix, the ability to disable automatic updates can streamline the build process, as the Nix ecosystem ensures consistent versioning. This would also allow us to maintain a good "runtime environment" without interruptions from update prompts.

I was thinking of adding an environment variable for this feature. Do you think that would be the best approach, or do you have other ideas in mind?

I’m happy to contribute to implementing this feature if you let me know your preferred approach.

Best,

@everyx
Copy link

everyx commented Nov 6, 2024

It may be possible to adjust the priority of customConfig so that it can override internalMozconfg ?

  const mergedConfig =
    `# This file is automatically generated. You should only modify this if you know what you are doing!\n\n` +
    commonConfig +
    '\n\n' +
    osConfig +
    '\n\n' +
-   customConfig +
-   '\n' +
-   internalMozconfg(brandingKey, dynamicConfig.get('buildMode'))
+   internalMozconfg(brandingKey, dynamicConfig.get('buildMode')) +
+   '\n' +
+   customConfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants