qdec in same70q21b not compiling, however in same70q21 works

[tswaehn]

It looks like there is an issue with using the QDEC in same70q21b vs same70q21.

When compiling with enabled sam-qdec I get an issue in that file:
drivers/sensor/qdec_sam/qdec_sam.c

missing definition of TC_CMR_ETRGEDG_NONE

.../zephyr/drivers/sensor/qdec_sam/qdec_sam.c: In function 'qdec_sam_configure':
.../zephyr/drivers/sensor/qdec_sam/qdec_sam.c:90:27: error: 'TC_CMR_ETRGEDG_NONE' undeclared (first use in this function); did you mean 'TC_CMR_ETRGEDG_Pos'?
   90 |                         | TC_CMR_ETRGEDG_NONE

this definition is present in:

asf/sam/include/same70/component/tc.h

but not present in:
asf/sam/include/same70b/component/tc.h

steps to reproduce
cmake
-DBOARD=sam_e70b_xplained (fails) vs -DBOARD=sam_e70_xplained (works)

dt

&tc0 {
	status = "okay";
	compatible = "atmel,sam-tc-qdec";

	pinctrl-0 = <&tc0_qdec_default>;
	pinctrl-names = "default";
	label = "QDEC_0";
};

conf

# quadrature decoder
CONFIG_SENSOR=y
CONFIG_QDEC_SAM=y

from the datasheet, I dont see any difference between both revision regarding qdec:

I suggest to copy paste from
same70/same70q21.h
to
same70b/same70q21b.h

[nandojve]

Hi @tswaehn ,

Please, open a PR on the hal and create a PR in Zephyr to update the hash.
Make sure you follow https://github.com/zephyrproject-rtos/hal_atmel#how-to-submit-code

[tswaehn]

@nandojve would be great if you could have an eye on the PR#35

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[tswaehn]

Finally I created the changes in hal_atmel

• qdec: same70b: Fix missing TC_CMR definitions hal_atmel#35

And also created a PR in zephyr (west.yaml) to point to the changeset in hal_atmel

• west.yml: update hal_atmel to include qdec SAME70b fix #68189

... I hope thats it, or did I miss something?