Replace fmt lib with C++20 std::format #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eager string generation instead of on-demand view
|
What do you think about this polyfill approach? https://stackoverflow.com/a/66989192 |
|
I don't think it's worth it. The main benefit of using std::format over fmt lib is a minor reduction of dependencies and the associated complexity. Trying to maintain both simultaneously would only make things worse in that aspect. As far as dependencies go, fmt lib is very unproblematic. I think keeping it around a little longer is totally fine. |
|
The question is, should this just be closed and reopened when it's possible to do so or should it kick around as a permanent draft PR? |
mmd-osm
added a commit
to mmd-osm/openstreetmap-cgimap
that referenced
this pull request
Mar 4, 2025
is_comma_separated_string is part of zerebubuth#474 and not yet merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging is not possible yet because
std::formatrequires GCC 13, which is not available in current Debian stable.Closes #469