Bogus OA setup in DataStorm

[pepone]

I think there is a chance here to receive a request before the connected callback is called and setups the OA.

ice/cpp/src/DataStorm/NodeSessionManager.cpp

Lines 340 to 354 in 8857b67

	lookup->createSessionAsync(
	proxy,
	[self = shared_from_this(), lookup](optional<NodePrx> node)
	{
	// createSession must return a non null proxy.
	assert(node);
	if (node)
	{
	self->connected(*node, lookup);
	}
	else
	{
	self->disconnected(lookup);
	}
	},

In Node implementation we use a different pattern with first calling getConnectionAsync and setup the OA before sending the request.

ice/cpp/src/DataStorm/NodeI.cpp

Lines 179 to 199 in 8857b67

	s->ice_getConnectionAsync(
	[=, self = shared_from_this()](const auto& connection) mutable
	{
	if (session->checkSession())
	{
	return;
	}
	if (connection)
	{
	if (!connection->getAdapter())
	{
	connection->setAdapter(instance->getObjectAdapter());
	}
	subscriberSession = subscriberSession->ice_fixed(connection);
	}
	try
	{
	// Must be called before connected
	s->confirmCreateSessionAsync(

Maybe we can simplify this by using the new setDefaultObjectAdapter.

[pepone]

Maybe we can simplify this by using the new setDefaultObjectAdapter.

I think we cannot because DataStorm doesn't always owns the communicator, and this could interfere with applications that pass they own communicator to DataStorm and also want to setup its own default OA.

[pepone]

Fixed in #3355